Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/sns_topic_policy - add disappears + refactor tests #14123

Merged
merged 6 commits into from
Apr 27, 2021
Merged

r/sns_topic_policy - add disappears + refactor tests #14123

merged 6 commits into from
Apr 27, 2021

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13826

Release note for CHANGELOG:

resource_aws_sns_topic_policy: add `owner` attribute
resource_aws_sns_topic_policy: add plan time validation to `arn`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSNSTopicPolicy_'
--- PASS: TestAccAWSSNSTopicPolicy_basic (50.74s)
--- PASS: TestAccAWSSNSTopicPolicy_updated (73.65s)
--- PASS: TestAccAWSSNSTopicPolicy_disappears_topic (30.39s)
--- PASS: TestAccAWSSNSTopicPolicy_disappears (41.43s)

@DrFaust92 DrFaust92 requested a review from a team July 9, 2020 20:55
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/sns Issues and PRs that pertain to the sns service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. documentation Introduces or discusses updates to documentation. labels Jul 9, 2020
@DrFaust92 DrFaust92 force-pushed the r/sns_policy_disappears branch from 6c7afaa to f41cd61 Compare September 30, 2020 21:12
@DrFaust92
Copy link
Collaborator Author

rebased

--- PASS: TestAccAWSSNSTopicPolicy_updated (87.13s)
--- PASS: TestAccAWSSNSTopicPolicy_disappears_topic (36.46s)
--- PASS: TestAccAWSSNSTopicPolicy_disappears (45.35s)
--- PASS: TestAccAWSSNSTopicPolicy_updated (87.13s)

Base automatically changed from master to main January 23, 2021 00:58
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:58
@DrFaust92 DrFaust92 force-pushed the r/sns_policy_disappears branch from c0e4f70 to c39076e Compare February 12, 2021 07:59
@DrFaust92 DrFaust92 force-pushed the r/sns_policy_disappears branch from c39076e to 862326c Compare March 27, 2021 16:54
@ewbankkit ewbankkit self-assigned this Apr 27, 2021
ewbankkit
ewbankkit approved these changes Apr 27, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSNSTopicPolicy_'                                                                                              
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSNSTopicPolicy_ -timeout 180m
=== RUN   TestAccAWSSNSTopicPolicy_basic
=== PAUSE TestAccAWSSNSTopicPolicy_basic
=== RUN   TestAccAWSSNSTopicPolicy_updated
=== PAUSE TestAccAWSSNSTopicPolicy_updated
=== RUN   TestAccAWSSNSTopicPolicy_disappears_topic
=== PAUSE TestAccAWSSNSTopicPolicy_disappears_topic
=== RUN   TestAccAWSSNSTopicPolicy_disappears
=== PAUSE TestAccAWSSNSTopicPolicy_disappears
=== CONT  TestAccAWSSNSTopicPolicy_basic
=== CONT  TestAccAWSSNSTopicPolicy_disappears
=== CONT  TestAccAWSSNSTopicPolicy_disappears_topic
=== CONT  TestAccAWSSNSTopicPolicy_updated
--- PASS: TestAccAWSSNSTopicPolicy_disappears_topic (11.83s)
--- PASS: TestAccAWSSNSTopicPolicy_disappears (14.92s)
--- PASS: TestAccAWSSNSTopicPolicy_basic (16.74s)
--- PASS: TestAccAWSSNSTopicPolicy_updated (26.44s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	29.334s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSNSTopicPolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSNSTopicPolicy_ -timeout 180m
=== RUN   TestAccAWSSNSTopicPolicy_basic
=== PAUSE TestAccAWSSNSTopicPolicy_basic
=== RUN   TestAccAWSSNSTopicPolicy_updated
=== PAUSE TestAccAWSSNSTopicPolicy_updated
=== RUN   TestAccAWSSNSTopicPolicy_disappears_topic
=== PAUSE TestAccAWSSNSTopicPolicy_disappears_topic
=== RUN   TestAccAWSSNSTopicPolicy_disappears
=== PAUSE TestAccAWSSNSTopicPolicy_disappears
=== CONT  TestAccAWSSNSTopicPolicy_basic
=== CONT  TestAccAWSSNSTopicPolicy_disappears
=== CONT  TestAccAWSSNSTopicPolicy_disappears_topic
=== CONT  TestAccAWSSNSTopicPolicy_updated
--- PASS: TestAccAWSSNSTopicPolicy_disappears_topic (15.99s)
--- PASS: TestAccAWSSNSTopicPolicy_disappears (19.11s)
--- PASS: TestAccAWSSNSTopicPolicy_basic (20.55s)
--- PASS: TestAccAWSSNSTopicPolicy_updated (34.48s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	37.339s

@ewbankkit ewbankkit merged commit 4ffaea8 into hashicorp:main Apr 27, 2021
@github-actions github-actions bot added this to the v3.38.0 milestone Apr 27, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2021
@DrFaust92 DrFaust92 deleted the r/sns_policy_disappears branch May 31, 2021 05:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. service/sns Issues and PRs that pertain to the sns service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.38.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DrFaust92 @ewbankkit