Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/ec2_traffic_mirror_filter_rule - add arn attribute #13949

Merged
merged 10 commits into from
Feb 11, 2021
Merged

r/ec2_traffic_mirror_filter_rule - add arn attribute #13949

merged 10 commits into from
Feb 11, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jun 25, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13624
Relates #13527
Relates #13826

Release note for CHANGELOG:

resource_aws_ec2_traffic_mirror_filter_rule: add arn attribute
resource_aws_ec2_traffic_mirror_filter_rule: plan time validation for `destination_port_range.from_port`, `destination_port_range.to_port`, `source_port_range.from_port` and `source_port_range.to_port`

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEc2TrafficMirrorFilterRule_'
--- PASS: TestAccAWSEc2TrafficMirrorFilterRule_basic (103.98s)
--- PASS: TestAccAWSEc2TrafficMirrorFilterRule_disappears (37.14s)

@DrFaust92 DrFaust92 requested a review from a team June 25, 2020 21:14
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 25, 2020
@DrFaust92 DrFaust92 force-pushed the r/ec2_traffic_mirror_filter_rule branch from c81aa9c to e53c652 Compare July 9, 2020 21:02
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 18, 2020
@DrFaust92 DrFaust92 force-pushed the r/ec2_traffic_mirror_filter_rule branch 2 times, most recently from 507efcf to 3d2201e Compare October 21, 2020 18:47
Base automatically changed from master to main January 23, 2021 00:58
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:58
@DrFaust92 DrFaust92 force-pushed the r/ec2_traffic_mirror_filter_rule branch from a935ca2 to 05b3f1d Compare February 11, 2021 13:17
@YakDriver YakDriver self-assigned this Feb 11, 2021
YakDriver
YakDriver approved these changes Feb 11, 2021
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

GovCloud:

--- PASS: TestAccAWSEc2TrafficMirrorFilterRule_disappears (16.77s)
--- PASS: TestAccAWSEc2TrafficMirrorFilterRule_basic (43.16s)

us-west-2:

--- PASS: TestAccAWSEc2TrafficMirrorFilterRule_disappears (14.28s)
--- PASS: TestAccAWSEc2TrafficMirrorFilterRule_basic (34.12s)

@YakDriver YakDriver added this to the v3.28.0 milestone Feb 11, 2021
@YakDriver YakDriver merged commit cc59465 into hashicorp:main Feb 11, 2021
@ghost
Copy link

ghost commented Feb 12, 2021

This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 13, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 13, 2021
@DrFaust92 DrFaust92 deleted the r/ec2_traffic_mirror_filter_rule branch April 15, 2021 10:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YakDriver YakDriver YakDriver approved these changes

Assignees

@YakDriver YakDriver

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. service/ec2 Issues and PRs that pertain to the ec2 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.28.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DrFaust92 @YakDriver