Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(sagemaker notebook): Add support for DefaultCodeRepository #13772

Merged
merged 1 commit into from
Oct 13, 2020
Merged

feature(sagemaker notebook): Add support for DefaultCodeRepository #13772

merged 1 commit into from
Oct 13, 2020

Conversation

harichandanp
Copy link

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #8959

Release note for CHANGELOG:

Add default_code_repository option to Sagemaker Notebook Instance resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSagemakerNotebookInstance_default_code_repository'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -count 1 -parallel 20 -run=TestAccAWSSagemakerNotebookInstance_default_code_repository -timeout 120m
?   	github.com/terraform-providers/terraform-provider-aws	[no test files]
=== RUN   TestAccAWSSagemakerNotebookInstance_default_code_repository
=== PAUSE TestAccAWSSagemakerNotebookInstance_default_code_repository
=== CONT  TestAccAWSSagemakerNotebookInstance_default_code_repository
--- PASS: TestAccAWSSagemakerNotebookInstance_default_code_repository (404.79s)

@harichandanp harichandanp requested a review from a team June 16, 2020 02:24
@ghost ghost added size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/sagemaker Issues and PRs that pertain to the sagemaker service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jun 16, 2020
@harichandanp
Copy link
Author

Can this be reviewed? Thanks

@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Aug 23, 2020
DrFaust92
DrFaust92 suggested changes Aug 23, 2020
View reviewed changes
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for adding this. some minor comments

aws/resource_aws_sagemaker_notebook_instance.go Outdated Show resolved Hide resolved
aws/resource_aws_sagemaker_notebook_instance_test.go Outdated Show resolved Hide resolved
aws/resource_aws_sagemaker_notebook_instance_test.go Outdated Show resolved Hide resolved
aws/resource_aws_sagemaker_notebook_instance_test.go Outdated Show resolved Hide resolved
aws/resource_aws_sagemaker_notebook_instance_test.go Outdated Show resolved Hide resolved
aws/resource_aws_sagemaker_notebook_instance_test.go Outdated Show resolved Hide resolved
aws/resource_aws_sagemaker_notebook_instance_test.go Outdated Show resolved Hide resolved
@DrFaust92
Copy link
Collaborator

Also forgot to add, please add this argument to docs as well. Thanks!

@harichandanp harichandanp force-pushed the feature/sagemaker-default-code-repositories branch from 6289fd5 to f3968ad Compare August 25, 2020 00:13
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Aug 25, 2020
@harichandanp
Copy link
Author

Addressed the comments, and updated the documentation

@harichandanp harichandanp force-pushed the feature/sagemaker-default-code-repositories branch from f3968ad to 6636230 Compare August 26, 2020 02:27
DrFaust92
DrFaust92 approved these changes Sep 23, 2020
View reviewed changes
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

--- PASS: TestAccAWSSagemakerNotebookInstance_update (705.35s)
--- PASS: TestAccAWSSagemakerNotebookInstance_LifecycleConfigName (393.58s)
--- PASS: TestAccAWSSagemakerNotebookInstance_tags (425.29s)
--- PASS: TestAccAWSSagemakerNotebookInstance_disappears (404.00s)
--- PASS: TestAccAWSSagemakerNotebookInstance_direct_internet_access (867.70s)
--- PASS: TestAccAWSSagemakerNotebookInstance_default_code_repository (409.72s)

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @harichandanp

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws TESTARGS='-run=TestAccAWSSagemakerNotebookInstance_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerNotebookInstance_ -timeout 120m
=== RUN   TestAccAWSSagemakerNotebookInstance_basic
=== PAUSE TestAccAWSSagemakerNotebookInstance_basic
=== RUN   TestAccAWSSagemakerNotebookInstance_update
=== PAUSE TestAccAWSSagemakerNotebookInstance_update
=== RUN   TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== PAUSE TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== RUN   TestAccAWSSagemakerNotebookInstance_tags
=== PAUSE TestAccAWSSagemakerNotebookInstance_tags
=== RUN   TestAccAWSSagemakerNotebookInstance_disappears
=== PAUSE TestAccAWSSagemakerNotebookInstance_disappears
=== RUN   TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== PAUSE TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== RUN   TestAccAWSSagemakerNotebookInstance_default_code_repository
=== PAUSE TestAccAWSSagemakerNotebookInstance_default_code_repository
=== CONT  TestAccAWSSagemakerNotebookInstance_basic
=== CONT  TestAccAWSSagemakerNotebookInstance_disappears
=== CONT  TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== CONT  TestAccAWSSagemakerNotebookInstance_tags
=== CONT  TestAccAWSSagemakerNotebookInstance_default_code_repository
=== CONT  TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== CONT  TestAccAWSSagemakerNotebookInstance_update
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (291.65s)
--- PASS: TestAccAWSSagemakerNotebookInstance_LifecycleConfigName (304.03s)
--- PASS: TestAccAWSSagemakerNotebookInstance_disappears (341.23s)
--- PASS: TestAccAWSSagemakerNotebookInstance_tags (346.06s)
--- PASS: TestAccAWSSagemakerNotebookInstance_default_code_repository (381.06s)
--- PASS: TestAccAWSSagemakerNotebookInstance_direct_internet_access (740.06s)
--- PASS: TestAccAWSSagemakerNotebookInstance_update (764.39s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	766.243s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TEST=./aws TESTARGS='-run=TestAccAWSSagemakerNotebookInstance_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerNotebookInstance_ -timeout 120m
=== RUN   TestAccAWSSagemakerNotebookInstance_basic
=== PAUSE TestAccAWSSagemakerNotebookInstance_basic
=== RUN   TestAccAWSSagemakerNotebookInstance_update
=== PAUSE TestAccAWSSagemakerNotebookInstance_update
=== RUN   TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== PAUSE TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== RUN   TestAccAWSSagemakerNotebookInstance_tags
=== PAUSE TestAccAWSSagemakerNotebookInstance_tags
=== RUN   TestAccAWSSagemakerNotebookInstance_disappears
=== PAUSE TestAccAWSSagemakerNotebookInstance_disappears
=== RUN   TestAccAWSSagemakerNotebookInstance_root_access
=== PAUSE TestAccAWSSagemakerNotebookInstance_root_access
=== RUN   TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== PAUSE TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== CONT  TestAccAWSSagemakerNotebookInstance_basic
=== CONT  TestAccAWSSagemakerNotebookInstance_disappears
=== CONT  TestAccAWSSagemakerNotebookInstance_tags
=== CONT  TestAccAWSSagemakerNotebookInstance_direct_internet_access
=== CONT  TestAccAWSSagemakerNotebookInstance_root_access
=== CONT  TestAccAWSSagemakerNotebookInstance_LifecycleConfigName
=== CONT  TestAccAWSSagemakerNotebookInstance_update
--- PASS: TestAccAWSSagemakerNotebookInstance_disappears (314.82s)
--- PASS: TestAccAWSSagemakerNotebookInstance_basic (342.15s)
--- PASS: TestAccAWSSagemakerNotebookInstance_tags (345.39s)
--- PASS: TestAccAWSSagemakerNotebookInstance_LifecycleConfigName (346.70s)
--- PASS: TestAccAWSSagemakerNotebookInstance_root_access (631.87s)
--- PASS: TestAccAWSSagemakerNotebookInstance_update (639.89s)
--- PASS: TestAccAWSSagemakerNotebookInstance_direct_internet_access (680.67s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	682.594s

@breathingdust breathingdust added this to the v3.11.0 milestone Oct 13, 2020
@breathingdust breathingdust merged commit c4e76fa into hashicorp:master Oct 13, 2020
breathingdust added a commit that referenced this pull request Oct 13, 2020
@breathingdust
Update CHANGELOG for #13772
cc49c6e
@ghost
Copy link

ghost commented Oct 15, 2020

This has been released in version 3.11.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 13, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DrFaust92 DrFaust92 DrFaust92 approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.11.0
Development

Successfully merging this pull request may close these issues.

feature(sagemaker notebook): Add Git Repository Support
3 participants
@harichandanp @DrFaust92 @breathingdust