Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo issue in step #3177

Closed
wants to merge 1 commit into from
Closed

fix: typo issue in step #3177

wants to merge 1 commit into from

Conversation

bilxio
Copy link

@bilxio bilxio commented Jan 4, 2022

Commit Checklist

Thank you for creating a pull request! To help us review / merge this can you make sure that your PR adheres as much as possible to the following.

The Basics

  • Commit is a single logical unit of work, only use multiple commits if doing different tasks
  • Commit does not include commented out code or unneeded files
  • rebase of main branch

The Content

  • Must include testing for bug or feature
  • Must include appropriate documentation changes if it is introducing a new feature or changing existing functionality
  • Must pass existing test suites

The Commit Message

  • Short meaningful description (ex: remove deprecated steps)
  • Uses the imperative, present tense: "change", not "changed" or "changes"
  • Includes motivation for the change, and contrasts its implementation with the previous behavior

The Pull Request

  • What is the reason for this change
  • Example usage of the failure for a bug, or configuration and expected output for a feature
  • Steps to test the change

@CLAassistant
Copy link

CLAassistant commented Jan 4, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@eoinmcafee00
Copy link

eoinmcafee00 commented Jan 10, 2022 •
edited
Loading

Hey @bilxio

Thank you for raising the PR. However, this would introduce a pretty major breaking change. The change is correct and will be fixed eventually as part of a major release.

Cheers,
Eoin

bot2-harness pushed a commit that referenced this pull request Jan 6, 2025
@shivanand-harness
feat: [AH-801]: Support ECR source in upstream proxy flow (#3177)
f4dfe93 
* feat: [AH-801] handle accessKeyType for gitness
* feat: [AH-801] update key for gitness
* feat: [AH-801]: support description and labels in upstream porxy create and update form
* feat: [AH-801]: fix breaking css from gitness
* feat: [AH-801]: implement MultiTypeSecretInput in HAR
* feat: [AH-801]: support ecr source in opensource
* feat: [AH-801]: Support ECR source in upstream proxy flow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bilxio @CLAassistant @eoinmcafee00