Support branch "create" action #3052
Conversation
go.mod
Outdated
| @@ -75,3 +75,5 @@ require ( | |||
| replace github.com/h2non/gock => gopkg.in/h2non/gock.v1 v1.0.14 | |||
|
|
|||
| go 1.13 | |||
|
|
|||
| replace github.com/drone/go-scm => github.com/quantonganh/go-scm v1.8.1-0.20210107022054-cb9eef77a93f | |||
There was a problem hiding this comment.
This should be removed prior to merging (but after blocking PR is merged)
There was a problem hiding this comment.
Of course. It's temporary to make the test passed.
quantonganh
force-pushed
the
i2685-branch-action
branch
from
d59107f to
03cf0cd
Compare
|
As @bradrydzewski pointed out, no need to add a new field to know if a branch has been created. We can do that by checking if the before commit is empty. Updated my PR. |
|
Hi @quantonganh i am unsure of this newly added behaviour, as it changes what existing drone users would expect. To move this forward in an open way i would suggest adding a proposal here https://github.com/drone/proposal. So we can design with the rest of the community what the behaviour should be and if the community as a whole needs this functionality. For now i am going to close this PR. Thank you for your submission and the time and effort you have put in. |
#2685
Discussion: https://gitter.im/drone/drone?at=5ff5c66acd31da3d9a961645