Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example/get all links #721 #729

Merged
merged 16 commits into from
Nov 4, 2018
Merged

Example/get all links #721 #729

merged 16 commits into from
Nov 4, 2018

Conversation

bdurrani
Copy link
Contributor

@bdurrani bdurrani commented Nov 2, 2018 •
edited by kblok
Loading

closes #721

I used this guide here for some conventions to try to keep things consistent as I make more examples.

I only tested this example on Windows for now.

@kblok
Copy link
Member

kblok commented Nov 2, 2018

Let's add here and item call "How to extract all the links from a page" with a file "Page.EvaluateExpressionAsync.GetAllLinks.md".
Make a copy of https://github.com/kblok/puppeteer-sharp/blob/master/docfx_project/examples/Page.ScreenshotAsync.md:

  • Add yourself as the contributor.
  • Explain the problem.
  • Copy there the code from line 16

@bdurrani bdurrani changed the title Example/get all links #721 [WIP] Example/get all links #721 Nov 2, 2018
@bdurrani
Copy link
Contributor Author

bdurrani commented Nov 4, 2018

@kblok updated as per your feedback

kblok
kblok requested changes Nov 4, 2018
View reviewed changes
Copy link
Member

@kblok kblok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! This is going to be awesome!

docfx_project/examples/Page.EvaluateExpressionAsync.GetAllLinks.md Outdated Show resolved Hide resolved
docfx_project/examples/toc.yml Outdated Show resolved Hide resolved
@bdurrani
Copy link
Contributor Author

bdurrani commented Nov 4, 2018

done!

@kblok
Copy link
Member

kblok commented Nov 4, 2018

Awesome! Is this still WIP? Or is it ready to be merged?

@bdurrani bdurrani changed the title [WIP] Example/get all links #721 Example/get all links #721 Nov 4, 2018
@bdurrani
Copy link
Contributor Author

bdurrani commented Nov 4, 2018

Its ready. I tested this on Windows 10.

@kblok kblok merged commit fb45c22 into hardkoded:master Nov 4, 2018
@bdurrani bdurrani deleted the example/get-all-links branch November 4, 2018 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kblok kblok kblok requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to get all the links from a page
2 participants
@bdurrani @kblok