Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement AppMode tests #340

Merged
merged 1 commit into from
Jun 24, 2018
Merged

Implement AppMode tests #340

merged 1 commit into from
Jun 24, 2018

Conversation

kblok
Copy link
Member

@kblok kblok commented Jun 23, 2018

closes #269

@Meir017
Copy link
Member

Meir017 commented Jun 23, 2018

feels a bit weird to implement the test even though it doesn't work 😕

@kblok
Copy link
Member Author

kblok commented Jun 23, 2018

Agreed. It sucks after spending many hours on this guy.
But technically speaking. AppMode is not only about pipes see https://github.com/GoogleChrome/puppeteer/pull/906/files

@kblok kblok merged commit 6940d59 into master Jun 24, 2018
@kblok kblok deleted the features/app-mode-tests branch June 24, 2018 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meir017 Meir017 Meir017 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement AppMode
2 participants
@kblok @Meir017