Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DocFx implementation #318

Merged
merged 6 commits into from
Jun 11, 2018
Merged

DocFx implementation #318

merged 6 commits into from
Jun 11, 2018

Conversation

kblok
Copy link
Member

@kblok kblok commented Jun 11, 2018

closes #160

@kblok kblok requested a review from Meir017 June 11, 2018 01:48
@@ -5,9 +5,16 @@ branches:
image: Visual Studio 2017
configuration: Release
environment:
git_access_token:
secure: FxcQ9C8a/NgcQB5dFdZts6ZWEDT4zMhA4qPQAYwWc7huMmhmTIl1sbFEIaAWQMTL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this on purpose?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's encrypted.

install:
- ps: >-
if($env:APPVEYOR_REPO_TAG -eq 'True' -And $env:framework -eq 'netcoreapp2.0') {
choco install docfx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is choco already installed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@@ -0,0 +1,108 @@
# Puppeteer Sharp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't the content of this file already in docfx_project/index.md?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docfx_project/index.md => Site home => https://www.puppeteersharp.com/
docfx_project/api/index.md => It's the API home => https://www.puppeteersharp.com/api/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we embed it into the other page?

@Meir017
Copy link
Member

Meir017 commented Jun 11, 2018

http://www.puppeteersharp.com/api/PuppeteerSharp.Page.html currently shows the inherited method from the Object class

image

@kblok
Copy link
Member Author

kblok commented Jun 11, 2018

@Meir017 site republished.

@kblok kblok merged commit ff583c3 into master Jun 11, 2018
@kblok kblok deleted the tasks/docs-site branch June 11, 2018 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish Documentation
2 participants