Allow ResponseData.Headers to support multiple values for the same key #1831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing Linux test case looks unrelated. Please let me know if you think it's related and I'll look into it further. |
kblok
reviewed
Oct 1, 2021
lib/PuppeteerSharp.Tests/RequestInterceptionTests/RequestRespondTests.cs
Outdated
Show resolved
Hide resolved
- Without breaking the current API this change allows for arrays of values (Anything that implements ICollection and can be iterated over). - The Headers with null values will be ignored, previously an exception would have occurred with the Value.ToString() call so this is unlikely a breaking change in behaviour. - New test case added Resolves hardkoded#1542
amaitland
force-pushed
the
enhancement/multipleheaders
branch
from
c283c24 to
37769a7
Compare
kblok
reviewed
Oct 4, 2021
kblok
reviewed
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Anything that implements ICollection and can be iterated over).
would have occurred with the Value.ToString() call so this is unlikely
a breaking change in behaviour.
Resolves #1542
Replaces #1607