Update hbmk2.prg #364
Merged
Update hbmk2.prg #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing feature, can't find windres.exe for MingW64 14.2.0 With this mod it will find it automatically otherwise it will give the resource not find error because it will look for i686-w64-mingw32-windres.exe instead of windres.exe.
|
Thank you |
|
Thank you for the patch @Hazaels. Though I do not agree with pulling commits as-is without valid ChangeLog.txt entry. Even git log message is not in ChangeLog format too. Note to @FiveTechSoft that you can force push to pull-request branch adding ChangeLog entry on behalf of the contributor. |
|
Dear Alexander,
many thanks for your advise. You are right, I forgot it.
best regards
El lun, 9 dic 2024 a las 10:58, Aleksander Czajczyński (<
***@***.***>) escribió:
… Thank you for the patch @Hazaels <https://github.com/Hazaels>. Though I
do not agree with pulling commits as-is without valid ChangeLog.txt entry.
Even git log message is not in ChangeLog format too. Note to @FiveTechSoft
<https://github.com/FiveTechSoft> that you can force push to pull-request
branch adding ChangeLog entry on behalf of the contributor.
—
Reply to this email directly, view it on GitHub
<#364 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACOC2UOBBJ7BN7TEG5ZE5XD2EVSTPAVCNFSM6AAAAABTGUPGFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRXGQ2TGNZTGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Antonio Linares
www.fivetechsoft.com
|
|
I agree with you.
It is a must to have the changelog reflect any change.
The problem is that I don't know how to do it... I just fixed the code but
I need to know step by step how to commit any fixes...
…On Mon, Dec 9, 2024 at 6:58 AM Aleksander Czajczyński < ***@***.***> wrote:
Thank you for the patch @Hazaels <https://github.com/Hazaels>. Though I
do not agree with pulling commits as-is without valid ChangeLog.txt entry.
Even git log message is not in ChangeLog format too. Note to @FiveTechSoft
<https://github.com/FiveTechSoft> that you can force push to pull-request
branch adding ChangeLog entry on behalf of the contributor.
—
Reply to this email directly, view it on GitHub
<#364 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA5ZZQWMR5AQI4WENV7HTWL2EVSTPAVCNFSM6AAAAABTGUPGFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRXGQ2TGNZTGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
alcz
added a commit
that referenced
this pull request
Dec 19, 2024
* contrib/rddsql/sqlbase.c
% cleanup unnecessary braces
* ChangeLog.txt
+ missing entry from pull request #364
JoseQuintas
pushed a commit
to JoseQuintas/harbour32
that referenced
this pull request
Dec 19, 2024
* contrib/rddsql/sqlbase.c
% cleanup unnecessary braces
* ChangeLog.txt
+ missing entry from pull request harbour#364
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing feature, can't find windres.exe for MingW64 14.2.0 With this mod it will find it automatically otherwise it will give the resource not find error because it will look for i686-w64-mingw32-windres.exe instead of windres.exe.