feat: add pagesDir glob #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you use |
hannoeru
reviewed
May 18, 2021
Closed
Can't because plugin initialization is sync, but I moved it to configResolved hook which is async |
|
Thanks, that is great! |
ckangwen
pushed a commit
to charrue/vite-plugin-pages
that referenced
this pull request
Jan 24, 2023
* feat: add pagesDir glob support * refact: move pageDir glob parsing to load handler * doc: add a glob in spa example * doc: fix glob example * doc: update spa example to add route links * refact: move pagesDirOptions glob parsing to configResolved hook * test: remove context-wise snapshot test * doc: improve getPageDirs doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this,
pagesDircan receive a glob string, so one can set multiplepagesdirectories using globs instead of fixed arrays