refactor: consistent route import for async and sync mode #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shkreios
force-pushed
the
main
branch
2 times, most recently
from
33c043a to
e9e089a
Compare
shkreios
changed the title
hannoeru
requested changes
Mar 18, 2022
I tried to configure prettier to look as similar as possible to your codestyle. Which styling tool are you using so I can easily revert the changes? Thanks |
|
Only ESLint, I don't want to have any coding style changes on the existing code in this PR. |
|
Ah sorry I thought you maybe had some tool, so contributors could easliy conform to the existing coding style. |
|
Just add a vscode settings to disable prettier in this repo, thanks for revert those changes. |
hannoeru
approved these changes
Mar 19, 2022
hannoeru
changed the title
ckangwen
pushed a commit
to charrue/vite-plugin-pages
that referenced
this pull request
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior
Async imports are handled inline
New behavior
Async imports are handled the same way as sync imports
Advantages