Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix font sizes and weights and migrate from Roboto to Overpass #287

Merged
merged 1 commit into from
Apr 3, 2017
Merged

Fix font sizes and weights and migrate from Roboto to Overpass #287

merged 1 commit into from
Apr 3, 2017

Conversation

kbrgl
Copy link
Contributor

@kbrgl kbrgl commented Mar 4, 2017

Fixes issue #235, making fonts in the docs much more pleasant and readable.

Summary of changes:

  • Change font used from Roboto to Overpass
  • Fix font sizes and weights
  • Enable font smoothing on WebKit based browsers (results in more crisp and clear fonts)
  • Change code background color

@kbrgl
Copy link
Contributor Author

kbrgl commented Mar 4, 2017

Screenshots:
screen shot 2017-03-04 at 12 14 24 pm
screen shot 2017-03-04 at 12 14 16 pm
screen shot 2017-03-04 at 12 14 10 pm
screen shot 2017-03-04 at 12 14 02 pm
screen shot 2017-03-04 at 12 13 50 pm

@kbrgl kbrgl closed this Mar 4, 2017
@kbrgl
Copy link
Contributor Author

kbrgl commented Mar 4, 2017

Sorry, closed accidentally 👅

GitHub should make this button harder to press!

@kbrgl kbrgl reopened this Mar 4, 2017
@cllns
Copy link
Member

cllns commented Mar 4, 2017

Oooh, I like this. :)

I think it could be nice to merge this when we release v1.0.0 proper, as a little visual docs bonus. OK with merging it sooner too though. Thanks for doing this! 🌸

@AlfonsoUceda
Copy link
Contributor

@kbrgl thanks for this PR, I really like it. @cllns I think we don't need to wait until v1.0.0 stable, what do you think @hanami/core

davydovanton
davydovanton approved these changes Apr 2, 2017
View reviewed changes
Copy link
Member

@davydovanton davydovanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome 👍

@AlfonsoUceda AlfonsoUceda merged commit a62692f into hanami:build Apr 3, 2017
jodosha added a commit that referenced this pull request Apr 6, 2017
@jodosha
Font for logotype is Roboto. Ref #287
ed03fcb
jodosha added a commit that referenced this pull request Apr 6, 2017
@jodosha
Font for logotype is Roboto. Ref #287
c691e39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davydovanton davydovanton davydovanton approved these changes

@jodosha jodosha jodosha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kbrgl @cllns @AlfonsoUceda @jodosha @davydovanton