Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Gradle 8.0.2 #3543

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind cleanup
/area core

What this PR does / why we need it:

Upgrade to Gradle 8.0.2 by using command ./gradlew wrapper --gradle-version 8.0.2 --distribution-type bin.

Recently, we have a plan to restructure our project via Gradle 8, so I upgrade to Gradle 8.0.2 now.

Does this PR introduce a user-facing change?

None

Signed-off-by: John Niang <johnniang@fastmail.com>
@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Mar 20, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and LIlGG March 20, 2023 14:31
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Mar 20, 2023
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #3543 (0db7074) into main (e6d2607) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #3543   +/-   ##
=========================================
  Coverage     61.65%   61.66%           
- Complexity     2510     2512    +2     
=========================================
  Files           398      398           
  Lines         12671    12671           
  Branches       1015     1015           
=========================================
+ Hits           7812     7813    +1     
+ Misses         4376     4374    -2     
- Partials        483      484    +1     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 20, 2023
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit f7eb0cd into halo-dev:main Mar 21, 2023
@ruibaby ruibaby added this to the 2.4.0 milestone Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants