Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create project infrastructure for halo-next #1699

Merged
merged 8 commits into from
Mar 4, 2022

Conversation

guqing
Copy link
Member

@guqing guqing commented Mar 3, 2022

What this PR does?

  1. 创建halo-next的基础结构,提供了包括gradle配置和application.yaml配置在内的一些信息
  2. flyway提供了对在h2、mysql、postgresql之前切换的migrate目录并经过了可行性验证
  3. checkstyle升级到最新版

将在下一个PR创建包结构和提供测试示例

参考文档:

docker run -d --name postgres -e POSTGRES_USER=postgres -e POSTGRES_PASSWORD=123456 postgres

Why we need it?

配置基础结构以方便开发halo-next

@guqing guqing requested review from JohnNiang and ruibaby March 3, 2022 10:19
@guqing guqing self-assigned this Mar 3, 2022
@guqing guqing added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 3, 2022
@guqing guqing added this to the 2.0 milestone Mar 3, 2022
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/main/resources/application.yaml Show resolved Hide resolved
build.gradle Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
@guqing guqing requested review from JohnNiang and ruibaby March 4, 2022 04:11
build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
@guqing guqing requested a review from JohnNiang March 4, 2022 06:45
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}
}

ext['h2.version'] = '2.1.210'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this works very well, please see:

 ? ? ? ~/workspaces/halo-dev/halo ? ? ? feature/skafford *1 ? ./gradlew dependencies | grep h2                                                                                                                                           ? ? 
+--- com.h2database:h2 -> 2.1.210
+--- com.h2database:h2 -> 2.1.210
+--- com.h2database:h2 (n)
+--- com.h2database:h2 -> 2.1.210

@JohnNiang JohnNiang merged commit e2843ad into halo-dev:next Mar 4, 2022
@guqing guqing deleted the feature/skafford branch March 4, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants