Add 'main' field in package.json for easier CommonJS loading #47
+4
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 would love to get this fix merged. |
hakimel
added a commit
that referenced
this pull request
Mar 25, 2015
Add 'main' field in package.json for easier CommonJS loading
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
for CommonJS / Browserify users, it is way easier to
requiremodules by their name, rather than by a path. I just added themainfield to the project's package.json to achieve this (browserify documentation), and also updated the example in the README.BTW if you do not want to merge this PR, the current CommonJS example does not work because the path needs to be prefixed by
./(var ladda = require('./Ladda/dist/ladda.min');).