Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic Go versions in vuln workflow #2800

Merged
merged 6 commits into from
Oct 2, 2023
Merged

Dynamic Go versions in vuln workflow #2800

merged 6 commits into from
Oct 2, 2023

Conversation

Skenvy
Copy link
Contributor

@Skenvy Skenvy commented Oct 2, 2023

What issue is this addressing?

Closes #2573

What type of issue is this addressing?

refactor

What this PR does | solves

Swap from hard coded versions of go to dynamically acquiring the latest stable versions from https://go.dev/dl/?mode=json

@Skenvy
Copy link
Contributor Author

Skenvy commented Oct 2, 2023

If not specifically avoiding participating in hacktoberfest, could this PR be labelled with "hacktoberfest-accepted" if that's alright?

hajimehoshi
hajimehoshi reviewed Oct 2, 2023
View reviewed changes
Copy link
Owner

@hajimehoshi hajimehoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

.github/workflows/vuln.yml Outdated Show resolved Hide resolved
.github/workflows/vuln.yml Outdated Show resolved Hide resolved
@hajimehoshi
Copy link
Owner

If not specifically avoiding participating in hacktoberfest, could this PR be labelled with "hacktoberfest-accepted" if that's alright?

That's fine! I'm not familiar with Hacktoberfest, but I was wondering if I have to create the label.

@Skenvy
Copy link
Contributor Author

Skenvy commented Oct 2, 2023 •
edited
Loading

If not specifically avoiding participating in hacktoberfest, could this PR be labelled with "hacktoberfest-accepted" if that's alright?

That's fine! I'm not familiar with Hacktoberfest, but I was wondering if I have to create the label.

There's a "for maintainers" section on the site here -- but essentially the two opt-in methods are either tagging the repo "hacktoberfest", or individual PRs "hacktoberfest-accepted".

@hajimehoshi
Copy link
Owner

There's a "for maintainers" section on the site here -- but essentially the two opt-in methods are either tagging the repo "hacktoberfest", or individual PRs "hacktoberfest-accepted".

Done (added a label)

hajimehoshi
hajimehoshi approved these changes Oct 2, 2023
View reviewed changes
Copy link
Owner

@hajimehoshi hajimehoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hajimehoshi hajimehoshi merged commit 8b587a1 into hajimehoshi:main Oct 2, 2023
@Skenvy Skenvy deleted the 2573 branch October 2, 2023 17:33
hajimehoshi pushed a commit that referenced this pull request Oct 2, 2023
@Skenvy @hajimehoshi
.github/workflows: dynamic Go versions in vuln workflow (#2800)
a27e3b6 
Swap from hard coded versions of go to dynamically acquiring
the latest stable versions from https://go.dev/dl/?mode=json

Closes #2573
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hajimehoshi hajimehoshi hajimehoshi approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

.github/workflows: use https://go.dev/dl/?mode=json to get Go versions for vuln.yml
2 participants
@Skenvy @hajimehoshi