-
-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/graphicsdriver/metal: remove C for macOS #2243
Conversation
# Conflicts: # internal/graphicsdriver/metal/graphics_macos_darwin.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There seems an error in the testing bot:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me test your PR on my MacBook Pro and iOS later. Thanks!
This reverts commit 8c8c860.
I found #2243 (comment) still exists. Please take a look, thanks |
yeah it wasn't linking to QuartzCore since that got removed from metal and wasn't in the iOS specific code. Should hopefully be fixed now. |
Other errors:
|
Hmm I’m not sure why it’s complaining on iOS although I did just remember I was using a modified version of purego so I’ll create that PR tomorrow morning |
So, we have to update purego in go.mod in this PR, right? |
Yes |
No problem, the const way is also fine! |
I'll test this with actual devices tomorrow, thanks! |
It seems like an iOS emulator and an actual iOS device worked with this PR. I'll double-check this PR as this is pretty big. |
I would test on actual device again since I did a pretty big refactor. I moved the common OBJC objects into the cocoa package because they will be needed when ports the rest of Ebitengine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
No description provided.