Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ebitenutil: add NewImageFromFileSystem() #2230

Merged
merged 3 commits into from
Aug 3, 2022
Merged

ebitenutil: add NewImageFromFileSystem() #2230

merged 3 commits into from
Aug 3, 2022

Conversation

raa0121
Copy link
Contributor

@raa0121 raa0121 commented Aug 3, 2022

close #1948

@hajimehoshi
Copy link
Owner

Ooh, I said please wait until I update the suggestion....

@raa0121 raa0121 force-pushed the new-image-from-filesystem branch from 9ec08ce to 234aeed Compare August 3, 2022 13:08
hajimehoshi
hajimehoshi approved these changes Aug 3, 2022
View reviewed changes
Copy link
Owner

@hajimehoshi hajimehoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@raa0121
Copy link
Contributor Author

raa0121 commented Aug 3, 2022

Is it better to rebase and combine commits ?

@hajimehoshi
Copy link
Owner

Is it better to rebase and combine commits ?

No, you don't have to do them

@hajimehoshi hajimehoshi merged commit c985010 into hajimehoshi:main Aug 3, 2022
@raa0121 raa0121 deleted the new-image-from-filesystem branch August 3, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hajimehoshi hajimehoshi hajimehoshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ebitenutil: add NewImageFromFileSystem()
2 participants
@raa0121 @hajimehoshi