Do not require installing file2byteslice to update go generate'd files. #2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tool is already referenced in
go.mod, so it is trivial to justgo runit - that way,go generatecan use it without the user explicitly installing it first.Tested: modifying
gobind.goand runninggo generatenow applies correctly togobind.src.go.Note that this means that
GOOS=windows go generateno longer will work on Linux - if this is a problem, we could prepend thegocommand withenv GOOS= GOARCH=every time. This same limitation also already exists for some of yourgo runcommands in there, though, so I thought it's fine to keep it that way.