Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ebiten: single thread via build tag #1396

Merged
merged 6 commits into from
Oct 20, 2020
Merged

ebiten: single thread via build tag #1396

merged 6 commits into from
Oct 20, 2020

Conversation

jakecoffman
Copy link
Contributor

updates #1367

hajimehoshi
hajimehoshi reviewed Oct 18, 2020
View reviewed changes
Copy link
Owner

@hajimehoshi hajimehoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

audio/audio.go Outdated Show resolved Hide resolved
internal/thread/thread.go Outdated Show resolved Hide resolved
hajimehoshi
hajimehoshi reviewed Oct 18, 2020
View reviewed changes
audio/audio.go Outdated Show resolved Hide resolved
hajimehoshi
hajimehoshi reviewed Oct 19, 2020
View reviewed changes
internal/sync/sync.go Outdated Show resolved Hide resolved
internal/shareable/image.go Outdated Show resolved Hide resolved
internal/thread/thread_noop.go Outdated Show resolved Hide resolved
internal/thread/thread.go Outdated Show resolved Hide resolved
internal/uidriver/glfw/run.go Outdated Show resolved Hide resolved
internal/sync/sync_noop.go Outdated Show resolved Hide resolved
hajimehoshi
hajimehoshi reviewed Oct 20, 2020
View reviewed changes
Copy link
Owner

@hajimehoshi hajimehoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an explanation about the build tag ebitensinglethread to doc.go.

internal/uidriver/glfw/run_notsinglethread.go Show resolved Hide resolved
internal/thread/thread.go Outdated Show resolved Hide resolved
hajimehoshi
hajimehoshi reviewed Oct 20, 2020
View reviewed changes
doc.go Outdated Show resolved Hide resolved
hajimehoshi
hajimehoshi approved these changes Oct 20, 2020
View reviewed changes
Copy link
Owner

@hajimehoshi hajimehoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hajimehoshi hajimehoshi merged commit 290f050 into hajimehoshi:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hajimehoshi hajimehoshi hajimehoshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakecoffman @hajimehoshi