Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delay of sound after not focusing the game window #975

Closed
wasedaigo opened this issue Nov 6, 2019 · 4 comments
Closed

Delay of sound after not focusing the game window #975

wasedaigo opened this issue Nov 6, 2019 · 4 comments
Assignees
@hajimehoshi
Labels
bug os:ios os:macos
Milestone
v1.10.1

Comments

@wasedaigo
Copy link
Contributor

wasedaigo commented Nov 6, 2019 •
edited
Loading

OS: Mac
ebiten version: ddba7f0

Repro Step:

  1. Leave the game unfocused
  2. Confirm the music delays after focusing the window

It seems the amount of delay is proportional to the time you were not focusing the window.
@hajimehoshi hajimehoshi added this to the v1.10.1 milestone Nov 6, 2019
@hajimehoshi hajimehoshi self-assigned this Nov 6, 2019
@hajimehoshi
Copy link
Owner

Confirmed.

hajimehoshi added a commit that referenced this issue Nov 6, 2019
@hajimehoshi
audio: Bug fix: Fill empty data even when audio is suspended
eca9f5f 
When writing is stopped on Oto's players, unexpected delaying
happens.

The ideal solution is to have APIs to suspend and resume Oto's
player, but this is not easy. For a temporary solution, write
zero values on the players when audio is suspended.

Fixes #975
hajimehoshi added a commit that referenced this issue Nov 9, 2019
@hajimehoshi
Revert "audio: Bug fix: Fill empty data even when audio is suspended"
5182060 
This reverts commit 529dddd.

Updates #975

Reason: This causes PARTIAL_WAKE_LOCK on Android (AudioDirectOut) (#931)
@hajimehoshi hajimehoshi reopened this Nov 9, 2019
@hajimehoshi
Copy link
Owner

The fix causes PARTIAL_WAKE_LOCK on Android.

hajimehoshi added a commit that referenced this issue Nov 9, 2019
@hajimehoshi
Revert "audio: Bug fix: Fill empty data even when audio is suspended"
a89e07f 
This reverts commit 529dddd.

Updates #975

Reason: This causes PARTIAL_WAKE_LOCK on Android (AudioDirectOut) (#931)
hajimehoshi added a commit to ebitengine/oto that referenced this issue Nov 10, 2019
@hajimehoshi
darwin: Bug fix: Pause the audio when input does not come
6298480 
Updates hajimehoshi/ebiten#975
hajimehoshi added a commit that referenced this issue Nov 10, 2019
@hajimehoshi
audio: Bug fix: Delay on macOS/iOS
3aef0e3 
Updates #975
@hajimehoshi
Copy link
Owner

I'll reflect this fix on 1.10 after Oto v0.5.3 is released.

hajimehoshi added a commit that referenced this issue Nov 10, 2019
@hajimehoshi
audio: Bug fix: Delay on macOS/iOS
b49e10d 
Updates #975
@hajimehoshi
Copy link
Owner

Now Ebiten has Oto v0.5.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hajimehoshi hajimehoshi

Labels
bug os:ios os:macos
Projects
None yet
Milestone
v1.10.1
Development

No branches or pull requests
2 participants
@hajimehoshi @wasedaigo