Added recipe for sqlitebrowser #969

tudor-nazarie · 2016-12-28T21:34:17Z

My take on the SQLite Browser task, not related to @vanishakesswani 's PR.

The recipe builds SQLiteBrowser and adds it to the Applications bar. It is noted as broken on x86_gcc2 as libqt4 is broken on that arch and QT 4 is a core dependency.

The only problem I could find was that the compilation seems to fail the first time it is run because of some missing translation files, but has no problems the second time it is run. I'm guessing that could be a problem on my system and might not appear on a fresh environment.

Other than that, I think Icon-O-Matic might have messed up the SVG file I used as an icon when exporting to HVIF.

fbrosson

Thanks @xdizzaster for your PR.
Here are a few recommended changes.

fbrosson · 2016-12-29T02:01:49Z

dev-db/sqlitebrowser/additional-files/sqlitebrowser.rdef

+resource app_version {
+	major  = 3,
+	middle = 9,
+	minor  = 1,


Although useing jhard-coded values in the rdef file is perfectly correct, we often rename the rdef file to rdef.in and use this:

major = @MAJOR@, middle = @MIDDLE@, minor = @MINOR@,

and later use sed to produce a rdef from the rdef.in.
I would recommend doing so for this recipe.
This has the advantage of not having to updated the rdef file (or the rdef.in file, since we rename it to make it clean that it has patterns.)

fbrosson · 2016-12-29T02:07:58Z

dev-db/sqlitebrowser/additional-files/sqlitebrowser.rdef

+	middle = 9,
+	minor  = 1,
+
+	variety = B_APPV_ALPHA,


I might be wroing, but I think that for the variety parameter we should use B_APPV_FINAL instead of B_APPV_ALPHA.

fbrosson · 2016-12-29T02:10:13Z

dev-db/sqlitebrowser/additional-files/sqlitebrowser.rdef

+	minor  = 1,
+
+	variety = B_APPV_ALPHA,
+	internal = 5,


I might be wroing, but I think that for the "internal" parameter we should use 0 instead of 5.

fbrosson · 2016-12-29T02:14:04Z

dev-db/sqlitebrowser/sqlitebrowser-3.9.1.recipe

+COPYRIGHT="2012-2016 Martin Kleusberg"
+LICENSE="GNU GPL v3"
+REVISION="1"
+SOURCE_URI="https://github.com/sqlitebrowser/sqlitebrowser/archive/v3.9.1.tar.gz"


Can you please replace

SOURCE_URI="https://github.com/sqlitebrowser/sqlitebrowser/archive/v3.9.1.tar.gz"

by

SOURCE_URI="https://github.com/sqlitebrowser/sqlitebrowser/archive/v$portVersion.tar.gz"

fbrosson · 2016-12-29T02:23:44Z

dev-db/sqlitebrowser/sqlitebrowser-3.9.1.recipe

+SOURCE_URI="https://github.com/sqlitebrowser/sqlitebrowser/archive/v3.9.1.tar.gz"
+CHECKSUM_SHA256="d0d2e06a69927ba1d0b955f3261ce70c61befc5bd5ddaa06752dae8bb4219ed8"
+PATCHES="sqlitebrowser-3.9.1.patchset"
+ADDITIONAL_FILES="sqlitebrowser.rdef"


Can you please replace

PATCHES="sqlitebrowser-3.9.1.patchset" ADDITIONAL_FILES="sqlitebrowser.rdef"

by

SOURCE_FILENAME="sqlitebrowser-$portVersion.tar.gz" PATCHES="sqlitebrowser-$portVersion.patchset" ADDITIONAL_FILES="sqlitebrowser.rdef.in"

Of course, this assumes you also

git mv sqlitebrowser.rdef sqlitebrowser.rdef.in git commit sqlitebrowser.rdef sqlitebrowser.rdef.in

Shouldn't I also change the name of sqlitebrowser.rdef when rc is called in BUILD()?

fbrosson · 2016-12-29T02:29:51Z

dev-db/sqlitebrowser/sqlitebrowser-3.9.1.recipe

+	cmd:qmake
+	cmd:make
+	cmd:g++$secondaryArchSuffix
+"


Please insert a tab before the closing double quotes.

BTW, it is recommentded to sort alphabetically the lines in BUILD_REQUIRES.

fbrosson · 2016-12-29T02:40:41Z

dev-db/sqlitebrowser/sqlitebrowser-3.9.1.recipe

+{
+	make $jobArgs install
+	mkdir -p $appsDir
+	mv $sourceDir/src/sqlitebrowser $appsDir/SQLiteBrowser


Please use cp instead of mv,because the latter would break haikuporter -F.

Hmm, it would be even better to pass some flags that wlould make sqlitebrowser get installed directly to $appsDir.

I'm not entirely sure how to change the install directory. I think it would require tinkering with qmake and I'm not very familiar with it. I think this suffices for now since SQLite Browser only has an executable (no icons or other files).

fbrosson · 2016-12-29T02:43:36Z

dev-db/sqlitebrowser/sqlitebrowser-3.9.1.recipe

+	sqlitebrowser$secondaryArchSuffix = $portVersion
+	app:sqlitebrowser$secondaryArchSuffix = $portVersion
+	"
+


Please remove the empty line between PROVIDES and REQUIRES.

fbrosson · 2016-12-29T02:45:08Z

dev-db/sqlitebrowser/sqlitebrowser-3.9.1.recipe

+	libqt4${secondaryArchSuffix}_devel
+	devel:libsqlite3$secondaryArchSuffix
+	"
+


Please remove the empty line between BUILD_REQUIRES and BUILD_PREREQUIRES .

tudor-nazarie · 2016-12-29T10:05:06Z

Hi! I updated the recipe and .rdef file according to your requests. Please see #969 (comment) regarding the call of rc and the resource file. Should I also rename it there?

korli · 2016-12-30T20:14:58Z

dev-db/sqlitebrowser/additional-files/sqlitebrowser.rdef.in

+	minor  = @MINOR@,
+
+	variety = B_APPV_FINAL,
+	internal = 0 ,


Please remove the space after 0

korli · 2016-12-30T20:15:32Z

dev-db/sqlitebrowser/sqlitebrowser-3.9.1.recipe

+	mkdir -p $appsDir
+	cp $sourceDir/src/sqlitebrowser $appsDir/SQLiteBrowser
+	addAppDeskbarSymlink $appsDir/SQLiteBrowser SQLiteBrowser
+	fixPkgconfig


Is this really necessary ?

You mean fixPkgconfig? I guess not since sqlitebrowser does not provide any dev libraries.

tudor-nazarie · 2016-12-30T20:21:33Z

Hi! I updated the PR with @korli 's requests, namely removed a stray whitespace and fixPkgconfig since it is not useful here.

tudor-nazarie · 2016-12-30T21:24:27Z

@korli I'm afraid you merged a broken recipe. Right now it will fail while trying to add the resource file to the binary because of a wrong filename. If you would have waited 60 more seconds, I would've pushed an updated that corrected this. Should I open a new PR to address this issue or how should I proceed?

korli · 2016-12-30T21:28:21Z

As you wish. If you've another gci task, don't spend too much time on this. Thanks!

tudor-nazarie mentioned this pull request Dec 28, 2016

sqlitebrowser:Added recipe #952

Closed

fbrosson reviewed Dec 29, 2016

View reviewed changes

tudor-nazarie force-pushed the sqlitebrowser branch from 2a51930 to fddfc44 Compare December 29, 2016 10:01

korli requested changes Dec 30, 2016

View reviewed changes

tudor-nazarie force-pushed the sqlitebrowser branch from fddfc44 to 1123901 Compare December 30, 2016 20:20

Added recipe for sqlitebrowser

f3c7b23

tudor-nazarie force-pushed the sqlitebrowser branch from 1123901 to f3c7b23 Compare December 30, 2016 21:01

korli merged commit 3ffe609 into haikuports:master Dec 30, 2016

tudor-nazarie mentioned this pull request Dec 30, 2016

Fixed recipe for sqlitebrowser #973

Merged

dacianf pushed a commit to dacianf/haikuports that referenced this pull request Jan 9, 2017

Added recipe for sqlitebrowser (haikuports#969)

2286cb9

korli pushed a commit to korli/haikuports that referenced this pull request Jan 26, 2017

Added recipe for sqlitebrowser (haikuports#969)

e233992

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added recipe for sqlitebrowser #969

Added recipe for sqlitebrowser #969

tudor-nazarie commented Dec 28, 2016

fbrosson left a comment

fbrosson Dec 29, 2016

fbrosson Dec 29, 2016

fbrosson Dec 29, 2016

fbrosson Dec 29, 2016

fbrosson Dec 29, 2016

tudor-nazarie Dec 29, 2016

fbrosson Dec 29, 2016

fbrosson Dec 29, 2016

tudor-nazarie Dec 29, 2016

fbrosson Dec 29, 2016

fbrosson Dec 29, 2016

tudor-nazarie commented Dec 29, 2016

korli Dec 30, 2016

korli Dec 30, 2016

tudor-nazarie Dec 30, 2016

tudor-nazarie commented Dec 30, 2016

tudor-nazarie commented Dec 30, 2016 •

edited

Loading

korli commented Dec 30, 2016

Added recipe for sqlitebrowser #969

Added recipe for sqlitebrowser #969

Conversation

tudor-nazarie commented Dec 28, 2016

fbrosson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tudor-nazarie commented Dec 29, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tudor-nazarie commented Dec 30, 2016

tudor-nazarie commented Dec 30, 2016 • edited Loading

korli commented Dec 30, 2016

tudor-nazarie commented Dec 30, 2016 •

edited

Loading