Cyrus-SASL : new recipe #2325
Cyrus-SASL : new recipe #2325
Conversation
There was a problem hiding this comment.
As for the patch, you could drop it and link with -lgnu for memmem(3). I've added it in ticket#13960
| @@ -0,0 +1,90 @@ | |||
| SUMMARY="The Cyrus SASL (Simple Authentication and Security Layer)" | |||
| DESCRIPTION="The Cyrus SASL library is a generic library for easy integration of secure network authentication to any client or server application. It supports authentication via standard plaintext methods as well as CRAM-MD5 and DIGEST-MD5 shared secret methods and KERBEROS_V4 and GSSAPI Kerberos methods. The SASL protocol framework is used by SMTP, IMAP, ACAP, LDAP, and other standard protocols." | |||
| @@ -0,0 +1,90 @@ | |||
| SUMMARY="The Cyrus SASL (Simple Authentication and Security Layer)" | |||
| DESCRIPTION="The Cyrus SASL library is a generic library for easy integration of secure network authentication to any client or server application. It supports authentication via standard plaintext methods as well as CRAM-MD5 and DIGEST-MD5 shared secret methods and KERBEROS_V4 and GSSAPI Kerberos methods. The SASL protocol framework is used by SMTP, IMAP, ACAP, LDAP, and other standard protocols." | |||
| HOMEPAGE="http://cyrusimap.web.cmu.edu/" | |||
| COPYRIGHT="1994-2012 Carnegie Mellon University" | ||
| LICENSE="BSD (4-clause)" | ||
| REVISION="1" | ||
| SOURCE_URI="https://github.com/cyrusimap/cyrus-sasl/archive/cyrus-sasl-2.1.27-rc7.tar.gz" |
There was a problem hiding this comment.
-SOURCE_URI="https://github.com/cyrusimap/cyrus-sasl/archive/cyrus-sasl-2.1.27-rc7.tar.gz"
+SOURCE_URI="https://github.com/cyrusimap/cyrus-sasl/archive/cyrus-sasl-${portVersion/~/-}.tar.gz"| REVISION="1" | ||
| SOURCE_URI="https://github.com/cyrusimap/cyrus-sasl/archive/cyrus-sasl-2.1.27-rc7.tar.gz" | ||
| CHECKSUM_SHA256="5a0c5475b35aad933c0f5939a360cfef86d06dbca93309cb7b223a38a133dc68" | ||
| SOURCE_DIR="cyrus-sasl-cyrus-sasl-2.1.27-rc7" |
There was a problem hiding this comment.
-SOURCE_DIR="cyrus-sasl-cyrus-sasl-2.1.27-rc7"
+SOURCE_DIR="cyrus-sasl-cyrus-sasl-${portVersion/~/-}"| cmd:pluginviewer$commandSuffix | ||
| cmd:saslauthd$commandSuffix | ||
| cmd:testsaslauthd$commandSuffix | ||
| lib:libsasl2$secondaryArchSuffix = 3.0.0 compat >= 3 |
There was a problem hiding this comment.
libVersionCompat should be used.
There was a problem hiding this comment.
libVersionCompatshould be used.
Well, it's not a requirement, so it would be better to write:
You might wish to define a libVersionCompat and use it here.
or
Shall we use a libVersionCompat here?
| rm $libDir/libsasl2.la | ||
| rm $libDir/sasl2/*.la | ||
|
|
||
| prepareInstalledDevelLibs libsasl2 |
There was a problem hiding this comment.
Suggestion:
- prepareInstalledDevelLibs libsasl2
+ prepareInstalledDevelLib libsasl2Yep, I know, both work.
(I'm suggesting this because this is a new recipe.)
|
|
||
| # remove libtool file | ||
| rm $libDir/libsasl2.la | ||
| rm $libDir/sasl2/*.la |
There was a problem hiding this comment.
Suggestion:
- rm $libDir/libsasl2.la
+ rm -f "$libDir"/libsasl2.la
- rm $libDir/sasl2/*.la
+ rm -f "$libDir"/sasl2/*.la(For new recipes, I would recommend using rm -f instead of just rm. This would reduce the git noise if/when new releases of libtool stop creating the libtool files.)
(Please feel free to ignore the double quotes if you don't like them. On new recipes I tend to use them, in case haikuporter is modified to allow non-chrooted builds.)
| BUILD_PREREQUIRES=" | ||
| cmd:aclocal | ||
| cmd:autoconf | ||
| cmd:automake |
There was a problem hiding this comment.
cmd:aclocal
- cmd:autoconf
cmd:automake
+ cmd:autoreconfThere was a problem hiding this comment.
@alaviss, there's a trick to make GitHub hide outdated comments: you just need to attach the comment to a line that is going to be changed or deleted.
And if your comment is for inserting a line before an existing line, say line N, the trick is to attach the comment to that line N. GitHub sees that line N has changed and understands that your comment has been addressed.
Here, you attached your comment to the line that has the cmd:automake, but this line is not being changed, so GitHub continues to show your comment because it thinks it was not addressed (although it was.)
Yep, I know, that's a bit tricky ;)
There was a problem hiding this comment.
@fbrosson My comment still got hidden :) AFAIK, GitHub will hide a comment if any of the lines shown on top the comment changes, not just the line I selected.
You might have seen the comment because you followed the link in "Notification" or the one in the email, which would show comments related to the changes in the commit.
|
@alaviss : it seems the builder needs a newer Haiku: |
Indeed. I'll look into updating the Haiku HPKG packages are built against later today. |
No description provided.