Decoding of Historic Data #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
restored support for negative temperatures added historic_data field in the README
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks alot to @gdyuldin and his support for historic data in #13 which is the base for this pull request.
With the help of my freezer compartment and the sun I figured out that the
historic_dataindeed capturesminandmaxvalues fortemperatureandhumidityper hour instead of the average I suspected first in #7 . Unfortunately the decoding wasn't correct so I fixed it here.I noticed the support for negative temperatures introduced in commit was overwritten so I restored it.
I also added a description in the README for the
historic_dataproperty