This repository has been archived by the owner on Dec 18, 2024. It is now read-only.
Rework make file, fix 'make install'. #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
h2337
reviewed
Sep 28, 2022
Makefile
Outdated
| @@ -17,29 +17,30 @@ CFLAGS:=-std=gnu11 -I$(INCLUDES) $(shell pkg-config --libs --cflags cairo x11 xf | |||
| CFILES:=$(shell find $(SOURCES) -printf '%P ' -name '*.c') | |||
| OFILES:=$(patsubst %.c,$(BUILD)/%.o,$(CFILES)) | |||
|
|
|||
| .PHONY: install build debug clean mkdir | |||
There was a problem hiding this comment.
Why did you remove install, debug, clean, and mkdir from .PHONY?
h2337
reviewed
Sep 28, 2022
| .DEFAULT_GOAL:=build | ||
|
|
||
| install: build | ||
| cd ./connmap/resources && unzip -n ipv4.csv.zip | ||
| cp -R ./connmap ~/.config/ | ||
| cp connmap.elf ~/.local/bin/connmap |
There was a problem hiding this comment.
Mind updating the instructions for running in README.md as well?
There was a problem hiding this comment.
Mind updating the instructions for running in
README.mdas well?
Done
h2337
added a commit
that referenced
this pull request
Dec 18, 2024
Rework make file, fix 'make install'.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General makefile fixes.
make installcopies binary to ~/.local/binmake cleanwont fail if debug (or normal) binaries don't exist.