Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Google-Translate-Popup #478

Closed
stritti opened this issue Sep 21, 2023 · 1 comment
Closed

Disable Google-Translate-Popup #478

stritti opened this issue Sep 21, 2023 · 1 comment

Comments

@stritti
Copy link

stritti commented Sep 21, 2023 •
edited
Loading

What were you doing?

Starting German page in fullscreen, there pops up an translation dialog of Google Translate.

What did you expect to happen?

No popup should be shown.

I think there should be one param updated at

FullPageOS/src/modules/fullpageos/filesystem/home/pi/scripts/start_chromium_browser

Line 4 in b810bf8

chromium-browser --kiosk --touch-events=enabled --disable-pinch --noerrdialogs --disable-session-crashed-bubble --simulate-outdated-no-au='Tue, 31 Dec 2099 23:59:59 GMT' --disable-component-update --overscroll-history-navigation=0 --disable-features=Translate --autoplay-policy=no-user-gesture-required --app=$(/home/pi/scripts/get_url)

from:

chromium-browser [...] --disable-features=Translate [...]

to:

chromium-browser [...] --disable-features=TranslateUI [...]

I used this in selfmade Kiosk sucessfully.

What happened instead?

Popup is shown as shown in screenshot below

Was there an error message displayed? What did it say?

Version of FullPageOS?

0.12.0

Screenshot(s) showing the problem:

IMG_1640
@guysoft
Copy link
Owner

guysoft commented Oct 26, 2023

Thanks for reporting, looks like it changed:

GoogleChrome/lighthouse#11860

https://chromium-review.googlesource.com/c/chromium/src/+/2404484

@guysoft guysoft closed this as completed in ef1a399 Nov 5, 2023
@guysoft guysoft mentioned this issue Apr 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stritti @guysoft