Fix directory iterator treating all files subsequent to a symlink as symlink on Windows #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix directory iterator treating all files subsequent to a symlink as symlink on Windows
|
Thank you for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to microsoft documentation on the
dwReserved0member of_WIN32_FIND_DATAW,reparse_tag_from_INFOusesdwReserved0without checking theFILE_ATTRIBUTE_REPARSE_POINTattribute, which causesdirectory_iteratorto use a staledwReserved0value for all files subsequent to a symlink, causing all of these files to be treated as symlink incorrectly.This patch checks
FILE_ATTRIBUTE_REPARSE_POINTbefore checkingdwReserved0to correctly get the symlink status of the files. Also replaced a hack that uses structure size to determine structure type with proper templates.This patch is tested on CleverRaven/Cataclysm-DDA#63612 and cherrypicked from that PR.