Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Axis labels are cut off when saving the table plot to a file #303

Closed
josp70 opened this issue Mar 10, 2024 · 2 comments
Closed

Axis labels are cut off when saving the table plot to a file #303

josp70 opened this issue Mar 10, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone
v0.20.0

Comments

@josp70
Copy link

josp70 commented Mar 10, 2024

We are generating chart in files but the axis labels are cut off in the generated files.

If we pass bbox_inches='tight' in the call to plt.savefig then the rendered labels are not cut off.

As a more general fix we can modify the method BinningTable.plot and redefined method in derived classes to accept a dictionary argument save_kwargs to be expanded in the call to plt.savefig
@josp70
Copy link
Author

josp70 commented Mar 10, 2024

A pull request has been proposed for this feature: #304

@guillermo-navas-palencia guillermo-navas-palencia added the enhancement New feature or request label Mar 11, 2024
@guillermo-navas-palencia guillermo-navas-palencia added this to the v0.20.0 milestone Mar 11, 2024
@guillermo-navas-palencia
Copy link
Owner

Thanks, I closed this issue since there is a PR fixing it.

josp70 pushed a commit to josp70/optbinning-issue-303 that referenced this issue Mar 15, 2024
ISSUE guillermo-navas-palencia#303, A function argument definition wi…
fbec93d 
…th a mutable type {} is a bad practice. Changing to save_kwargs=None
josp70 pushed a commit to josp70/optbinning-issue-303 that referenced this issue Mar 24, 2024
ISSUE guillermo-navas-palencia#303, add documentation for save_kwargs
c2cde2c
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.20.0
Development

No branches or pull requests
2 participants
@josp70 @guillermo-navas-palencia