Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize input of NERModel::predict_full_entities #329

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Generalize input of NERModel::predict_full_entities #329

merged 1 commit into from
Jan 23, 2023

Conversation

akeamc
Copy link
Contributor

@akeamc akeamc commented Jan 22, 2023

Make the input parameter of pipelines::ner::NERModel::predict_full_entities as generic as NERModel::predict.

guillaume-be
guillaume-be approved these changes Jan 23, 2023
View reviewed changes
Copy link
Owner

@guillaume-be guillaume-be left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@guillaume-be guillaume-be merged commit 80e0197 into guillaume-be:master Jan 23, 2023
Miezhiko pushed a commit to Masha/rust-bert that referenced this pull request Mar 21, 2023
@akeamc @Miezhiko
Generalize input of NERModel::predict_full_entities (guillaume-be#329)
4bd52b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaume-be guillaume-be guillaume-be approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akeamc @guillaume-be