This repository has been archived by the owner on Jun 21, 2022. It is now read-only.
make the policy managed, encrypt the EBS #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only just seen this! Change looks reasonable to me and I think makes sense to make it compulsory for everyone, unless there is a downside that doesn't occur to me. Not sure I can comment on the writer policy change though. Why is that necessary? |
|
the writer policy is so we can apply that policy to other instances rather than just being in this cloudformation. Maybe I didn't know how to do it otherwise though! |
jfsoul
approved these changes
Nov 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been installing this for the subs team, and we really need to encrypt our logs due to PII risk.
I also need to reference the kinesis writer policy so I can attach it to my instances' role.
Not sure if these are changes that should apply to everyone, but they could be parameterised if necessary.
@adamnfish @jfsoul @TBonnin you guys have been PRing this project recently so you can critique my PR 😛