-
Notifications
You must be signed in to change notification settings - Fork 483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #771, Guard now fails with the 1 exit code when plugin is not available #791
Conversation
Fixes #771, i.e. running 'bundle exec guard init rspec' with guard-rspec not available will exit with the 1 exit code.
That's exactly how it should work. The only thing I'd change is to use a custom exception instead of Kind of like here: https://github.com/guard/guard/blob/771-non-zero-exit-code-when-plugin-unavailable/lib/guard/cli/environments/valid.rb#L35 Ideally, the Anyway, I'm fine with just replacing |
Thanks for the feedback @e2 and sorry for not replying earlier! I will update the PR asap! ;) |
@rymai - don't worry about it :) I'm the one who hasn't done much in Guard for a long time. (Though I mostly wanted to make sure Listen 3.x works for people without issues first - especially in Spring, so I avoided changing "too much") |
|
||
def initialize(plugin_name) | ||
@plugin_name = plugin_name | ||
@class_name = plugin_name.gsub("-", "").capitalize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary spacing detected.
a527ec0
to
d686a18
Compare
Here you go @e2! It feels good to work on Guard again, I hope I'll have more time to contribute from now on. |
…-unavailable Fix #771, Guard now fails with the 1 exit code when plugin is not available
Awesome! Makes me want to get back to contributing a bit more too ;) |
i.e. running 'bundle exec guard init rspec' with guard-rspec not
available will exit with the 1 exit code.
@e2 Is it an acceptable solution?