Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend remote_state backend check to include *.tf.json files #401

Merged
merged 1 commit into from
Jan 11, 2018

Conversation

tamsky
Copy link
Contributor

@tamsky tamsky commented Jan 10, 2018

Original test in #302 only examined files matching **/*.tf.

This PR adds support for *.tf.json files.

Neither test parses the HCL or json, and instead looks for a hardcoded regex.
Given that the test is a best-effort at helping folks, I don't think we should start parsing anything.

#302 (comment)

make fmt clean.

Test output clean:
go-test-output.txt

Copy link
Member

@brikis98 brikis98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@brikis98 brikis98 merged commit 4123182 into gruntwork-io:master Jan 11, 2018
@brikis98
Copy link
Member

Binaries should be here soon: https://github.com/gruntwork-io/terragrunt/releases/tag/v0.13.24

@tamsky
Copy link
Contributor Author

tamsky commented Jan 12, 2018

Teammates and I thank you for another very speedy release!
Best.

@tamsky tamsky deleted the enhance/pull/302 branch January 12, 2018 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants