Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adding golangci style lints #3347

Closed
wants to merge 7 commits into from

Conversation

yhakbar
Copy link
Collaborator

@yhakbar yhakbar commented Aug 15, 2024

Description

Addresses some style linting.

The documentation has improved somewhat. I'll be honest, and I didn't think too hard about the comments I used, but I tried to make sure they weren't inaccurate.

Running the following:

godoc -http=:6060

Then navigating here:
http://localhost:6060/pkg/github.com/gruntwork-io/terragrunt/

Will show some of the docs changes.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Updated package amazonsts
Updated package awshelper
Updated package awshelper_test
Updated package awsproviderpatch
Updated package awsproviderpatch_test
Updated package buttonbar
Updated package cache
Updated package catalog
Updated package cli
Updated package cli_test
Updated package cliconfig
Updated package codegen
Updated package codegen_test
Updated package command
Updated package commands
Updated package config
Updated package config_test
Updated package configstack
Updated package configstack_test
Updated package controllers
Updated package creds
Updated package diagnostic
Updated package dynamodb
Updated package dynamodb_test
Updated package engine
Updated package externalcmd
Updated package getproviders
Updated package getproviders_test
Updated package graph
Updated package graphdependencies
Updated package handlers
Updated package hclfmt
Updated package hclfmt_test
Updated package hclparse
Updated package hclvalidate
Updated package helpers
Updated package integration_test
Updated package log
Updated package main
Updated package module
Updated package module_test
Updated package options
Updated package outputmodulegroups
Updated package providers
Updated package remote
Updated package remote_test
Updated package renderjson
Updated package router
Updated package runall
Updated package runall_test
Updated package scaffold
Updated package scaffold_test
Updated package services
Updated package shell
Updated package shell_test
Updated package telemetry
Updated package terraform
Updated package terraform_test
Updated package terragruntinfo
Updated package tflint
Updated package tui
Updated package util
Updated package util_test
Updated package validateinputs
Updated package validateinputs_test
Updated package view

@yhakbar yhakbar force-pushed the chore/adding-golangci-style-lints branch from fb37d0c to 4d596ae Compare August 15, 2024 20:42
@yhakbar yhakbar force-pushed the chore/adding-golangci-style-lints branch from 4d596ae to 70080d7 Compare August 16, 2024 12:48
@yhakbar yhakbar force-pushed the chore/adding-golangci-style-lints branch from 89eb759 to b171254 Compare August 16, 2024 13:23
@yhakbar
Copy link
Collaborator Author

yhakbar commented Aug 16, 2024

This PR is basically unreviewable and changes too much to be stable. Will revisit another time.

@yhakbar yhakbar closed this Aug 16, 2024
Copy link

@yhakbar yhakbar mentioned this pull request Aug 16, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant