Initial catalog implementation #2815
Conversation
| ), | ||
| Filter: key.NewBinding( | ||
| key.WithKeys("/"), | ||
| key.WithHelp("/", "filter"), |
There was a problem hiding this comment.
Maybe "filter / search"? I think some folks will be looking for the word "search."
There was a problem hiding this comment.
Also, what content is getting indexed? Is it just the README for each module? The module name and folder name? Something else? And is it doing exact matches? Or fuzzy matching? Case sensitive?
There was a problem hiding this comment.
Maybe "filter / search"? I think some folks will be looking for the word "search."
It's better to set only one of them, otherwise / can be confused with a hotkey
I renamed to "search", I agreed it's clearer.
Also, what content is getting indexed? Is it just the README for each module? The module name and folder name? Something else? And is it doing exact matches? Or fuzzy matching? Case sensitive?
Only the module name is indexed with fuzzy and case-insensitive matching.
There was a problem hiding this comment.
Roger!
Could you add a follow-up ticket to index the module README as well?
There was a problem hiding this comment.
Sure, created the GH issue #2833.
|
Ah, but make sure tests pass before merging! |
Thanks for the review! |
Description
Add a new CLI command
catalogthat launches the user interface for searching and managing Terraform modules.Fixes #2796.