Adding ability to shutdown a connect server #217
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 3, 2016 10:37
The new grunt task allows a user to execute a grunt comment to shutdown the already started server.
The shutdown method has been updated to cater for multiple servers running in parallel.
|
Why hasn't this been merged years ago? This feature is critical to the success of this project. is it just waiting for tests? |
|
Any updates on when this will be merged? |
|
Has this been implemented yet? I could really use this functionality. |
|
If this was rebased and a test was added, we could merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extension of issue #117, which relates to issue #83.
This works for me, but I don't know how to write tests for it (i.e. I could use some help writing a test for this).
Fixes #83