A51 update: Allow cpu_utilization larger than 1.0 #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@markdroth @dfawley FYI |
markdroth
changed the title
ejona86
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
We'll delay merging a bit to let cncf/xds#60 go in.
For posterity: we noticed that if the CPU saturates at 100% when the provided CPU is over 100% (because it was a soft limit, and additional CPU happens to be available) the WRR weights become essentially "qps". Then you get a runaway effect where the backend with highest qps gets more and more qps sent to it. If the system allows the CPU to exceed 100%, it is better to just communicate that to keep the qps:cpu ratio consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.