Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use charset from StandardCharsets instead of 'Charset.forName' #8779

Merged
merged 3 commits into from
Jan 7, 2022
Merged

use charset from StandardCharsets instead of 'Charset.forName' #8779

merged 3 commits into from
Jan 7, 2022

Conversation

JintaoXIAO
Copy link
Contributor

as described in the title

thanks
(sorry for my poor English :) )

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 22, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@dapengzhang0
Copy link
Member

StandardCharsets is added in Java 7 and Android API level 19 and thus is supported by the latest grpc-java.

@dapengzhang0
Copy link
Member

The failing tests should pass once #8814 is merged.

@dapengzhang0 dapengzhang0 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jan 7, 2022
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jan 7, 2022
@dapengzhang0 dapengzhang0 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jan 7, 2022
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jan 7, 2022
@dapengzhang0 dapengzhang0 merged commit a74a3ad into grpc:master Jan 7, 2022
@dapengzhang0
Copy link
Member

@JintaoXIAO Thank you!

dapengzhang0 added a commit to dapengzhang0/grpc-java that referenced this pull request Jan 18, 2022
@dapengzhang0
Revert "use charset from StandardCharsets instead of 'Charset.forName' (
d40fe5b 
grpc#8779)"

This reverts commit a74a3ad.
This was referenced Jan 18, 2022
Closed
Merged
dapengzhang0 added a commit that referenced this pull request Jan 18, 2022
@dapengzhang0
Revert "use charset from StandardCharsets instead of 'Charset.forName' (
3179bc3 
#8779)"

This reverts commit a74a3ad.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dapengzhang0 dapengzhang0 dapengzhang0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JintaoXIAO @dapengzhang0 @grpc-kokoro