interop-testing: Use normal runtimeOnly dep for xds #7200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents grpc-xds and its transitive dependencies from being included twice in distTar and distZip, which reduces the size from 60 MB to 40 MB. It does mean that interop-testing as a whole depends on xds, but that should not be an issue any longer. It was an issue before we started providing grpc-xds on Maven Central.
|
Is the GAE Interop failure legit? |
|
@dapengzhang0, yes, the GAE failure is legit. |
dapengzhang0
approved these changes
Jul 13, 2020
dfawley
pushed a commit
to dfawley/grpc-java
that referenced
this pull request
Jan 15, 2021
This prevents grpc-xds and its transitive dependencies from being included twice in distTar and distZip, which reduces the size from 60 MB to 40 MB. It does mean that interop-testing as a whole depends on xds, but that should not be an issue any longer. It was an issue before we started providing grpc-xds on Maven Central.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents grpc-xds and its transitive dependencies from being included
twice in distTar and distZip, which reduces the size from 60 MB to 40 MB. It
does mean that interop-testing as a whole depends on xds, but that should not
be an issue any longer. It was an issue before we started providing grpc-xds on
Maven Central.