Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interop-testing: update test proto to match grpc-proto. #5003

Merged
merged 4 commits into from
Oct 30, 2018

Conversation

creamsoup
Copy link
Contributor

@creamsoup creamsoup commented Oct 26, 2018

  • Remove deprecated message PayloadType in messages.proto. This affected many test case, because old server can pass the deprecated field which is part of equals.
  • Use BoolValue instead of well known proto to match other languages.

Note: this changed proto will be used in stubby4 server (test server for cloud to cloud test).
Also, grpc/grpc-proto repo will get the same update.

@creamsoup creamsoup requested review from carl-mastrangelo and removed request for carl-mastrangelo October 26, 2018 01:01
@creamsoup creamsoup force-pushed the interop branch 5 times, most recently from fb34049 to 9be9632 Compare October 29, 2018 22:19
@creamsoup
Copy link
Contributor Author

This PR includes some generated code which maybe ignored. However, AbstractInteropTest.java is also collapsed which may need some attention.

@creamsoup creamsoup changed the title interop-testing: update test proto to use protobuf empty. interop-testing: update test proto to match grpc-proto. Oct 29, 2018
@creamsoup creamsoup merged commit 51ab5b9 into grpc:master Oct 30, 2018
@creamsoup creamsoup deleted the interop branch October 30, 2018 18:16
@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants