Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error codes cheat sheet for the new "Safer Intent" rules. #11639

Merged
merged 4 commits into from
Oct 25, 2024
Merged

Update error codes cheat sheet for the new "Safer Intent" rules. #11639

merged 4 commits into from
Oct 25, 2024

Conversation

jdcormie
Copy link
Member

@jdcormie
Copy link
Member Author

Sorry for the messy diff but IIRC but this table needs rowspans and so the only way to express it was raw HTML. The new case has to go at the beginning to fit in with the other cases that map to UNIMPLEMENTED

ejona86
ejona86 approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, having that many cases does make things annoying on insert. But choices are limited.

@jdcormie jdcormie merged commit fe350cf into grpc:master Oct 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@groakley groakley groakley left review comments

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdcormie @ejona86 @groakley