api: Add java.time.Duration overloads to CallOptions, AbstractStub #11562

SreeramdasLavanya · 2024-09-26T13:33:07Z

Overloading API's containing long, TimeUnit with java.time.Duration

Fixes #10245

…h Duration" This reverts commit ab97045.

linux-foundation-easycla · 2024-09-26T13:33:13Z

The committers listed above are authorized under a signed CLA.

✅ login: SreeramdasLavanya (ab97045, 778cfb4, c1090b7, 3dbb61e, eb66fe5, 84a37e9, 4113845, 328bcbf, af01908, 0b6c594, 62a88ec, 4531bc2, 7207da8, 6c56aae, 6a66054, e64f659, f01209b, db6c21f, e76d673, 09c3509, bd5a80a, de2e185, bf6c521, b905dfa, 7d9bfdf, 7e46762, e530050, 6a713ed, fef4c92, 27df5f9, 89afd10, 4d0aa82, 301ff57, 761a812, 1dd8bbc, de91ea3, 75c8955)

kannanjgithub · 2024-09-27T06:18:40Z

api/src/context/java/io/grpc/Deadline.java

@@ -95,6 +101,11 @@ public static Deadline after(long duration, TimeUnit units, Ticker ticker) {
    return new Deadline(ticker, units.toNanos(duration), true);
  }

+  public static Deadline after(Duration duration, Ticker ticker) {
+    return after(TimeUnit.NANOSECONDS.convert(duration.getSeconds(), TimeUnit.SECONDS),


I have a concern about the loss of precision, I have raised a question on Eric's comment to use TimeUnit.NANOSECONDS.convert(duration) instead of Duration.toNano().

As Eric replied, you should be using https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/util/concurrent/TimeUnit.html#convert(java.time.Duration) and not have to convert using the seconds value.

…adlineTest files

api/src/main/java/io/grpc/SynchronizationContext.java

api/src/test/java/io/grpc/SynchronizationContextTest.java

stub/src/main/java/io/grpc/stub/AbstractStub.java

api/src/main/java/io/grpc/InternalTimeUtils.java

kannanjgithub · 2024-10-16T06:20:58Z

api/src/main/java/io/grpc/InternalTimeUtils.java

+
+import java.time.Duration;
+
+@Internal


@internal is used to mark certain classes as should not be used by user code. This class being just a util helper, there is no need to mark it as Internal. Also drop the Internal prefix from the class and file name and make it just TimeUtils.

Well, this is public in a public package, so the @Internal is needed.

api/src/main/java/io/grpc/TimeUtils.java

…er review comments

ejona86

We need @ExperimentalApi on all the new public API methods (those receiving Duration).

ejona86 · 2024-10-22T14:50:55Z

api/src/main/java/io/grpc/InternalTimeUtils.java

+
+import java.time.Duration;
+
+@Internal


Well, this is public in a public package, so the @Internal is needed.

api/src/main/java/io/grpc/InternalTimeUtils.java

api/src/main/java/io/grpc/LoadBalancer.java

api/src/main/java/io/grpc/SynchronizationContext.java

stub/src/main/java/io/grpc/stub/AbstractStub.java

api/src/main/java/io/grpc/CallOptions.java

…ving Duration and reverted LoadBalancer code.

api/src/main/java/io/grpc/SynchronizationContext.java

ejona86 · 2024-10-29T17:03:33Z

api/src/main/java/io/grpc/SynchronizationContext.java

@@ -162,6 +164,12 @@ public String toString() {
    return new ScheduledHandle(runnable, future);
  }

+  @ExperimentalApi("https://github.com/grpc/grpc-java/issues/10245")


These links should point to a new issue created to track stabilizing this API. (See issues with the "experimental API" label for examples.)

SreeramdasLavanya and others added 9 commits September 20, 2024 14:25

SynchronizationContextTest changes for scheduleFixedDelay with Duration

ab97045

Revert "SynchronizationContextTest changes for scheduleFixedDelay wit…

fef4c92

…h Duration" This reverts commit ab97045.

SynchronizationContextTest changes for scheduleFixedDelay with Duration

6a713ed

SynchronizationContextTest checkstyle issues updated for issue10245

db6c21f

Merge branch 'grpc:master' into master

778cfb4

Merge branch 'grpc:master' into master

328bcbf

Merge branch 'grpc:master' into master

6a66054

Issue 10245 fix for long, TimeUnit to java.time.Duration to API's

84a37e9

Issue 10245 - Fixed Checkstyle issues

c1090b7

Issue 10245 - Fixed Checkstyle issues

6c56aae

kannanjgithub reviewed Sep 27, 2024

View reviewed changes

SreeramdasLavanya and others added 2 commits October 1, 2024 12:13

Merge branch 'grpc:master' into master

4113845

Issue 10245 - Reverted java.time.Duration changes for Deadline and De…

4531bc2

…adlineTest files

SreeramdasLavanya changed the title ~~Fix for long, TimeUnit to java.time.Duration changes to API's~~ grpc-api: Changing long, TimeUnit to java.time.Duration Oct 4, 2024

SreeramdasLavanya and others added 2 commits October 8, 2024 09:36

Merge branch 'grpc:master' into master

09c3509

Issue 10245 - Implementation for Duration.toNanos() changes

bd5a80a

SreeramdasLavanya mentioned this pull request Oct 8, 2024

Add java.time.Duration overloads to CallOptions, AbstractStub, Deadline, and other APIs #10245

Closed

kannanjgithub reviewed Oct 9, 2024

View reviewed changes

api/src/main/java/io/grpc/SynchronizationContext.java Outdated Show resolved Hide resolved

kannanjgithub reviewed Oct 9, 2024

View reviewed changes

api/src/test/java/io/grpc/SynchronizationContextTest.java Show resolved Hide resolved

kannanjgithub reviewed Oct 9, 2024

View reviewed changes

stub/src/main/java/io/grpc/stub/AbstractStub.java Show resolved Hide resolved

SreeramdasLavanya and others added 7 commits October 9, 2024 11:09

grpc-api/stub: Implementation for InternalTimeUtil under grpc-api module

e64f659

grpc-api/stub: Added JUnit for the InternalTimeUtils changes

0b6c594

Merge branch 'master' into FixIssue10245

4d0aa82

Merge branch 'grpc:master' into master

62a88ec

Merge branch 'master' into FixIssue10245

b905dfa

grpc-api/stub: Modified JUnit for the InternalTimeUtils changes

eb66fe5

grpc-api: Whitespace formatting for unrelated code

e76d673

kannanjgithub reviewed Oct 16, 2024

View reviewed changes

api/src/main/java/io/grpc/InternalTimeUtils.java Show resolved Hide resolved

kannanjgithub reviewed Oct 16, 2024

View reviewed changes

grpc-kokoro removed kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run labels Oct 17, 2024

SreeramdasLavanya changed the title ~~grpc-api: Changing long, TimeUnit to java.time.Duration~~ api: Add java.time.Duration overloads to CallOptions, AbstractStub Oct 18, 2024

grpc-api/stub: Renamed convert() method to convertToNanos()

af01908

kannanjgithub reviewed Oct 21, 2024

View reviewed changes

api/src/main/java/io/grpc/TimeUtils.java Show resolved Hide resolved

SreeramdasLavanya added 3 commits October 22, 2024 13:30

grpc-api/stub: Changes for InternalTimeUtils and TimeUtils files as p…

3dbb61e

…er review comments

grpc-api/stub: Checkstyle issue

7e46762

grpc-api/stub: Check style issue for InternalTimeUtils

e530050

ejona86 reviewed Oct 22, 2024

View reviewed changes

grpc-api/stub: Included @experimentalapi for public API.

7d9bfdf

ejona86 reviewed Oct 23, 2024

View reviewed changes

grpc-api/stub: Included @experimentalapi for public API's those recei…

301ff57

…ving Duration and reverted LoadBalancer code.

ejona86 reviewed Oct 24, 2024

View reviewed changes

api/src/main/java/io/grpc/SynchronizationContext.java Show resolved Hide resolved

SreeramdasLavanya and others added 2 commits October 25, 2024 08:03

Merge branch 'grpc:master' into FixIssue10245

de91ea3

grpc-api/stub: Included schedule() with Duration

27df5f9

ejona86 approved these changes Oct 25, 2024

View reviewed changes

ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Oct 25, 2024

grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Oct 25, 2024

SreeramdasLavanya added 2 commits October 29, 2024 11:39

grpc-api: Included private constructor

89afd10

grpc-api: Fix checkstyle issue

75c8955

ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Oct 29, 2024

grpc-kokoro removed kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run labels Oct 29, 2024

ejona86 reviewed Oct 29, 2024

View reviewed changes

SreeramdasLavanya and others added 2 commits October 30, 2024 07:36

Merge branch 'grpc:master' into FixIssue10245

1dd8bbc

grpc-api/stub: Created new issue for ExperimentalApi

761a812

kannanjgithub added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Oct 30, 2024

grpc-kokoro removed kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run labels Oct 30, 2024

kannanjgithub merged commit 766b923 into grpc:master Oct 30, 2024
15 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

api: Add java.time.Duration overloads to CallOptions, AbstractStub #11562

api: Add java.time.Duration overloads to CallOptions, AbstractStub #11562

SreeramdasLavanya commented Sep 26, 2024 •

edited

Loading

linux-foundation-easycla bot commented Sep 26, 2024 •

edited

Loading

kannanjgithub Sep 27, 2024

kannanjgithub Oct 3, 2024

kannanjgithub Oct 16, 2024

ejona86 Oct 22, 2024

ejona86 left a comment

ejona86 Oct 22, 2024

ejona86 Oct 29, 2024


		import java.time.Duration;

		@Internal


		import java.time.Duration;

		@Internal

api: Add java.time.Duration overloads to CallOptions, AbstractStub #11562

api: Add java.time.Duration overloads to CallOptions, AbstractStub #11562

Conversation

SreeramdasLavanya commented Sep 26, 2024 • edited Loading

linux-foundation-easycla bot commented Sep 26, 2024 • edited Loading

kannanjgithub Sep 27, 2024

Choose a reason for hiding this comment

kannanjgithub Oct 3, 2024

Choose a reason for hiding this comment

kannanjgithub Oct 16, 2024

Choose a reason for hiding this comment

ejona86 Oct 22, 2024

Choose a reason for hiding this comment

ejona86 left a comment

Choose a reason for hiding this comment

ejona86 Oct 22, 2024

Choose a reason for hiding this comment

ejona86 Oct 29, 2024

Choose a reason for hiding this comment

SreeramdasLavanya commented Sep 26, 2024 •

edited

Loading

linux-foundation-easycla bot commented Sep 26, 2024 •

edited

Loading