-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark MultiChildLoadBalancer as Internal. #10481
Conversation
…package because of its use of classes in the util package.
Yeah, ForwardingLoadBalancerHelper should really be in
They are essentially doing it wrong as well. The only RoundRobinLoadBalancer is public as a hack to share code with WRR, which had to be implemented very quickly. There should be some code sharing, but we haven't gotten that nice yet (and this base class might actually replace what was done there). OutlierDetectionLoadBalancer looks to be public because the config is used from xds. That should just use json and the Provider. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the super short-term (like this coming release), we can accept this, but let's exclude it from the Javadoc as well. Add to util/build.gradle
(and confirm it isn't present in the javadoc):
tasks.named("javadoc").configure {
exclude 'io/grpc/util/MultiChildLoadBalancer.java'
}
interop-testing/build.gradle
Outdated
@@ -186,3 +186,7 @@ publishing { | |||
} | |||
} | |||
} | |||
|
|||
tasks.named("javadoc").configure { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this? I didn't think this was needed.
* Mark MultiChildLoadBalancer as Internal. Cannot move to the internal package because of its use of classes in the util package. * Exclude MultiChildLoadBalancer from javadoc generation. * Fix javadoc creation.
Cannot move to the intern package because of its use of classes in the util package.
There is precedence for using the @internal annotation as it is being done by outlier detection and round robin.