examples: fix debugging example after Dial->NewClient migration #7833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7833 +/- ##
==========================================
+ Coverage 81.90% 81.92% +0.01%
==========================================
Files 374 374
Lines 37978 37978
==========================================
+ Hits 31105 31112 +7
+ Misses 5579 5572 -7
Partials 1294 1294 |
easwars
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a comment in #7049.
The
manualpackage'sUpdateStatemethod cannot be used until after a client attempts to connect. Maybe that behavior should be change, but this example really wants to useInitialStateanyway. Also, make the client and server listen on different ports for channelz, so they can both run at the same time.RELEASE NOTES: