Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiple: add verbosity checks to logs that use pretty.JSON #7785

Merged
merged 1 commit into from
Oct 28, 2024
Merged

multiple: add verbosity checks to logs that use pretty.JSON #7785

merged 1 commit into from
Oct 28, 2024

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Oct 25, 2024

RELEASE NOTES: none

@easwars easwars requested a review from zasweq October 25, 2024 22:13
@easwars easwars added the Type: Internal Cleanup Refactors, etc label Oct 25, 2024
@easwars easwars added this to the 1.68 Release milestone Oct 25, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 81.30%. Comparing base (94e1b29) to head (8b03364).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
balancer/rls/config.go 0.00% 2 Missing and 1 partial ⚠️
balancer/rls/control_channel.go 0.00% 2 Missing and 1 partial ⚠️
balancer/weightedtarget/weightedtarget.go 0.00% 2 Missing and 1 partial ⚠️
...internal/balancer/clustermanager/clustermanager.go 0.00% 2 Missing and 1 partial ⚠️
...ternal/balancer/clusterresolver/clusterresolver.go 0.00% 2 Missing and 1 partial ⚠️
xds/internal/balancer/ringhash/ringhash.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7785      +/-   ##
==========================================
- Coverage   81.40%   81.30%   -0.10%     
==========================================
  Files         368      368              
  Lines       36779    36788       +9     
==========================================
- Hits        29939    29910      -29     
- Misses       5613     5639      +26     
- Partials     1227     1239      +12
Files with missing lines Coverage Δ
balancer/rls/config.go 81.59% <0.00%> (-1.64%) ⬇️
balancer/rls/control_channel.go 93.12% <0.00%> (-2.30%) ⬇️
balancer/weightedtarget/weightedtarget.go 89.36% <0.00%> (-3.03%) ⬇️
...internal/balancer/clustermanager/clustermanager.go 73.14% <0.00%> (-2.56%) ⬇️
...ternal/balancer/clusterresolver/clusterresolver.go 67.10% <0.00%> (-1.04%) ⬇️
xds/internal/balancer/ringhash/ringhash.go 87.62% <0.00%> (-0.96%) ⬇️

... and 21 files with indirect coverage changes

@zasweq
Copy link
Contributor

zasweq commented Oct 28, 2024

You might need to rebase onto the most recent upstream master and then force push in order to trigger 1.23.

@zasweq zasweq assigned easwars and unassigned zasweq Oct 28, 2024
@easwars easwars merged commit 192ee33 into grpc:master Oct 28, 2024
14 checks passed
@easwars easwars deleted the verbosity_checks branch October 28, 2024 21:58
@dfawley
Copy link
Member

dfawley commented Oct 28, 2024

What was the motivation for this change? All of these operations are on the control plane, so shouldn't need to be too optimized (in theory).

@easwars
Copy link
Contributor Author

easwars commented Oct 28, 2024

There was some noise about this on an internal bug. So, I thought I will spend a couple of minutes and fix it.

misvivek pushed a commit to misvivek/grpc-go that referenced this pull request Nov 7, 2024
@easwars @misvivek
multiple: add verbosity checks to logs that use pretty.JSON (grpc#7785)
85997c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zasweq zasweq zasweq approved these changes

Assignees

@easwars easwars

Labels
Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
1.68 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@easwars @zasweq @dfawley