pickfirstleaf: minor simplification to reconcileSubConnsLocked method #7731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7731 +/- ##
==========================================
+ Coverage 81.96% 81.99% +0.02%
==========================================
Files 362 362
Lines 28119 28116 -3
==========================================
+ Hits 23048 23053 +5
+ Misses 3863 3858 -5
+ Partials 1208 1205 -3
|
janardhanvissa
pushed a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Oct 15, 2024
sagarsudo
pushed a commit
to sagarsudo/grpc-go
that referenced
this pull request
Oct 16, 2024
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a minor simplification to the
reconcileSubConnsLockedmethodThis PR also adds a docstring to the method instead of inline comments, some of which were a little stale.
RELEASE NOTES: none