Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: misc test cleanup (4/N) #7695

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Oct 2, 2024

#a71-xds-fallback
#xdsclient-refactor

Addresses #6902

RELEASE NOTES: none

@easwars easwars added this to the 1.68 Release milestone Oct 2, 2024
@easwars easwars requested review from purnesh42H and zasweq October 2, 2024 18:03
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.94%. Comparing base (3adcd41) to head (6e6884f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7695      +/-   ##
==========================================
+ Coverage   81.75%   81.94%   +0.19%     
==========================================
  Files         361      361              
  Lines       27827    27827              
==========================================
+ Hits        22749    22803      +54     
+ Misses       3870     3838      -32     
+ Partials     1208     1186      -22     
Files with missing lines Coverage Δ
internal/testutils/channel.go 83.33% <ø> (ø)

... and 16 files with indirect coverage changes

@zasweq zasweq self-requested a review October 4, 2024 20:01
@zasweq zasweq assigned easwars and unassigned zasweq Oct 4, 2024
@easwars easwars force-pushed the misc_test_cleanup branch from 0ed4b21 to 6e6884f Compare October 7, 2024 23:28
@easwars easwars merged commit 5e6f4b9 into grpc:master Oct 7, 2024
14 checks passed
@easwars easwars deleted the misc_test_cleanup branch October 7, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants