xds: Fix flaky test TestUnmarshalListener_WithUpdateValidatorFunc #7675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjan-bal
added
Type: Testing
Area: Testing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7675 +/- ##
==========================================
+ Coverage 81.80% 81.95% +0.15%
==========================================
Files 361 361
Lines 27821 27822 +1
==========================================
+ Hits 22758 22802 +44
+ Misses 3862 3835 -27
+ Partials 1201 1185 -16 |
arjan-bal
force-pushed
the
fix-flaky-test
branch
from
02dbd20 to
9142e41
Compare
easwars
approved these changes
Oct 1, 2024
| select { | ||
| case <-readyLis.serverReady.Done(): | ||
| case <-time.After(defaultTestTimeout): | ||
| t.Fatalf("Timed out while waiting for the back end server to start") |
There was a problem hiding this comment.
Nit: s/to start/to start serving/
There was a problem hiding this comment.
Updated the error message as suggested.
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7599
This change ensures that the server has started listening for requests by wrapping the listener passed to
server.Serve()Verified that the test no longer flakes in 100000 runs on forge.
RELEASE NOTES: N/A