.*: fix revive lints redefines-builtin-id
#7552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-error-flow, var-declaration
Optimising the code by fixing var-declaration, indent-error-flow, increment-decrement, superfluous-else
…low, increment-decrement, superfluous-else"
Revert "Optimising the code by fixing var-declaration, indent-error-flow, increment-decrement, superfluous-else"
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7552 +/- ##
==========================================
+ Coverage 81.75% 81.87% +0.12%
==========================================
Files 361 361
Lines 27813 27813
==========================================
+ Hits 22739 22773 +34
+ Misses 3870 3845 -25
+ Partials 1204 1195 -9
|
purnesh42H
reviewed
Aug 26, 2024
…to linter-emtyblk-builtin-id
…to linter-emtyblk-builtin-id
…to linter-emtyblk-builtin-id
purnesh42H
reviewed
Aug 27, 2024
|
@janardhanvissa make sure to keep the comments upto line col 80 |
|
@purnesh42H Updated the comments as suggested and pushed the changes. Please re-review it. |
…hanvissa/grpc-go into linter-emtyblk-builtin-id
purnesh42H
reviewed
Aug 28, 2024
purnesh42H
reviewed
Aug 28, 2024
purnesh42H
approved these changes
Aug 28, 2024
purnesh42H
changed the title
redefines-builtin-id, empty-block
purnesh42H
reviewed
Sep 5, 2024
| @@ -506,6 +506,7 @@ func (ccw *stateRecordingCCWrapper) NewSubConn(addrs []resolver.Address, opts ba | |||
| func keepReading(conn net.Conn) { | |||
| buf := make([]byte, 1024) | |||
| for _, err := conn.Read(buf); err == nil; _, err = conn.Read(buf) { | |||
|
|
|||
There was a problem hiding this comment.
@janardhanvissa revert this empty line please
arvindbr8
approved these changes
Sep 6, 2024
Co-authored-by: Arvind Bright <arvind.bright100@gmail.com>
purnesh42H
added
the
Area: Tooling
…to linter-emtyblk-builtin-id
…hanvissa/grpc-go into linter-emtyblk-builtin-id
|
@purnesh42H Updated close to closeFn as mentioned above. Please re-review the changes. |
|
We should have probably rebased and removed this TODO. |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #7444
RELEASE NOTES: None