Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/tools: update staticcheck version to latest #7509

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Aug 14, 2024

RELEASE NOTES: none

@easwars easwars requested a review from dfawley August 14, 2024 16:31
@easwars easwars added this to the 1.66 Release milestone Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.68%. Comparing base (3cb3342) to head (ed1e638).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7509      +/-   ##
==========================================
- Coverage   81.76%   81.68%   -0.08%     
==========================================
  Files         359      359              
  Lines       27515    27532      +17     
==========================================
- Hits        22498    22490       -8     
- Misses       3804     3821      +17     
- Partials     1213     1221       +8     

see 21 files with indirect coverage changes

Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this, but it triggers a new vet failure now. Can you take a look?

@easwars
Copy link
Contributor Author

easwars commented Aug 14, 2024

I'm fine with this, but it triggers a new vet failure now. Can you take a look?

Fixed the failures. Thanks.

@dfawley dfawley assigned easwars and unassigned dfawley Aug 14, 2024
@easwars easwars merged commit 6d7f07c into grpc:master Aug 14, 2024
11 checks passed
@easwars easwars deleted the update_staticcheck branch August 14, 2024 21:32
infovivek2020 pushed a commit to infovivek2020/grpc-go that referenced this pull request Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants